1.09b Discussion

[Hell_Tempest]

Would it be possible so that if you hire a unit when the counter is four, just instantly give them the amount of money they paid for it?

[Rising_Dusk]

It already does that and has forever..

[SetaSoujirou]

The main concern here is when the UNITS go on CD when someone tells the team to buy out a lane. Then they all go on a rampage and knock out all the units.

[Rising_Dusk]

Yes, I spent days of my life trying to work on a fix for that. There just isn't one.

[Uber Noob]

Remove control of the structure once it reaches 4 and give control back once it goes down to 3 or lower.

Kinda cheap, but it would work. Would it?

Another idea: when it reaches 4, have the game force the user to select a dummy structure that has no units for sale but has the "number of spawns" icon visible. Anyone else (minus enemies, obviously) clicking on the structure would be redirected to this structure as well. Once it goes back down to 3, function as normal.

You could make this structure a tiny invisible unit that's on top of the main structure or something. Keep the selection circle the same size but make the selection scale for this unit nonexistent if possible so it looks like there was no change in behavior.

Any of those possible?

[Rising_Dusk]

Remove control of the structure once it reaches 4 and give control back once it goes down to 3 or lower.

Kinda cheap, but it would work. Would it?

That's an inelegant solution.

Another idea: when it reaches 4, have the game force the user to select a dummy structure that has no units for sale but has the "number of spawns" icon visible. Anyone else (minus enemies, obviously) clicking on the structure would be redirected to this structure as well. Once it goes back down to 3, function as normal.

This could work (still kind of inelegant), but there's a lag between selection and the trigger firing. I could run it on a timer and do a periodic check, but I'm kind of averse to running a 0.033 timer for this sort of thing.

Any of those possible?

Possible? Yeah, elegant? No. That's the real killer for me.

[Deschain]

Are those dummy units (like a mercenary) or items?

If they are items you could give them some requirement, no? Like Ancient of Wonders has Tier 2/3 as requirements to have some items? Just create/destroy requirement for items to be enabled/disabled respectively.

[Uber Noob]

I actually had a third suggestion, but I didn't post it because I thought it was a bit excessive, but here goes anyway. Maybe it'd be better:

Similar to my second suggestion, however when the main structure reaches 4 spawns, swap it with an identical dummy structure and move the main structure to the middle of nowhere and change the ownership to a different player (14?) so it is not visible and make it invulnerable. The dummy structure will now actually be the 'main' structure, with the same hit points and such. If anyone was attacking/selecting the main structure when it got swapped then they'll be redirected to attack/select the dummy structure.

When the spawn amount goes back down to 3 or lower, swap the dummy structure back with the main structure and reissue the attack orders on everyone that was attacking the dummy structure (if any). Also re-set the HP of the main structure to whatever the dummy structure had.

How about that? Is it possible to make the swap instantaneous so people can't even notice a change?

[Deschain]

How about that? Is it possible to make the swap instantaneous so people can't even notice a change?

I think he was reffering to it being inelegant. Since it is the easiest solution there is.

[Uber Noob]

This one is a little different. The main structure would be moved to 'nowhere' so there wouldn't have to be periodic triggers for people clicking it. Whoever was already on it would be reissued to select/attack/whatever on the dummy structure.

Example: Player clicks a spawn to buy and that is the 4th spawn... this causes triggers to swap the main structure with a dummy structure and re-issue orders for everyone who was already interacting with the main structure to the dummy structure.

I believe moving units is pretty much instantaneous so you wouldn't see the 'swap' of the structure. It's the same thing with hero deaths, the corpses remain. It's actually a dummy unit of the hero...The dying hero is moved somewhere and a dummy unit playing the hero's death is put in its place.

[Rising_Dusk]

Example: Player clicks a spawn to buy and that is the 4th spawn... this causes triggers to swap the main structure with a dummy structure and re-issue orders for everyone who was already interacting with the main structure to the dummy structure.

Except that there are 8 independent spawn types you can buy from a place with 8 independent counters for how many are remaining. In order for the counts between the original structure and the dummy to match (ie. elegant solution), you'd need to set them as such. The problem therein is that you cannot within the framework of WC3 detect what the current count left is. Without being able to dynamically test it, there's no way to dynamically set it, and you cannot do this dummy structure replacement method with any degree of elegance.

I also think it would look rather silly if I just removed the numbers for the dummy structure. The sin of perfection, I guess you'd say.

[Deschain]

You can't use requirement to disable it like racial shops do?

[T.s.e-kun]

Code: Select all

library Spawns initializer Init

    globals
        private constant integer ORDERSPAWNER = 'a010'
        private constant integer BANESPAWNER  = 'b010'
        private player triggerer
        private integer startgold
        private integer startlumber
        private integer OCOUNTER = 0
        private integer BCOUNTER = 0
        private boolean BANE = null
    endglobals


private function Actions takes nothing returns nothing
    local Spawns s = Spawns.create()
    local unit u = GetSellingUnit()
    local unit s = GetSoldUnit()
    if BANE = true then
        if OCOUNTER > 4 then
            if GetUnitTypeId(s) == 'dragon' or GetUnitTypeId(s) == 'golem' then
                call AddUnitToStock(u, GetUnitTypeId(s), 0, 1)
                call RemoveUnit( GetSoldUnit())
                call SetPlayerState(triggerer, PLAYER_STATE_RESOURCE_GOLD, startgold)
                call SetPlayerState(triggerer, PLAYER_STATE_RESOURCE_LUMBER, startlumber)
            endif
        call AddUnitToStock(u, GetUnitTypeId(s), 4-OCOUNTER, 4)
        call RemoveUnit(GetSoldUnit())
        call SetPlayerState(triggerer, PLAYER_STATE_RESOURCE_GOLD, startgold)
        call SetPlayerState(triggerer, PLAYER_STATE_RESOURCE_LUMBER, startlumber)
    endif
    call SetUnitOwner(s, GetOwningPlayer(u), true)
    endif
    if BANE = false then
    if OCOUNTER > 4 then
            if GetUnitTypeId(s) == 'obliderator' or GetUnitTypeId(s) == 'crag' then
                call AddUnitToStock(u, GetUnitTypeId(s), 0, 1)
                call RemoveUnit( GetSoldUnit())
                call SetPlayerState(triggerer, PLAYER_STATE_RESOURCE_GOLD, startgold)
                call SetPlayerState(triggerer, PLAYER_STATE_RESOURCE_LUMBER, startlumber)
            endif
        call AddUnitToStock(u, GetUnitTypeId(s), 4-OCOUNTER, 4)
        call RemoveUnit(GetSoldUnit())
        call SetPlayerState(triggerer, PLAYER_STATE_RESOURCE_GOLD, startgold)
        call SetPlayerState(triggerer, PLAYER_STATE_RESOURCE_LUMBER, startlumber)
    endif
    call SetUnitOwner(s, GetOwningPlayer(u), true)
    endif
    set u = null
    set s = null
endfunction
    
private function Cond takes nothing returns boolean
    if GetUnitTypeId( GetSellingUnit()) == ORDERSPAWNER then
        set OCOUNTER = OCOUNTER + 1
        set BANE = false
        return true
    elseif GetUnitTypeId( GetSellingUnit()) == BANESPAWNER then
        set BCOUNTER = BCOUNTER + 1
        set BANE = true
        return true
    endif
    return false
endfunction
    
private function Safe takes nothing returns boolean
    return true
endfunction
    
private function Init takes nothing returns nothing
    local trigger t = CreateTrigger()
    local integer i = 0
    loop
        call TriggerRegisterPlayerUnitEvent(t, Player(i), EVENT_PLAYER_UNIT_SELL, Filter(function Safe))
        set triggerer = Player(i)
        set startgold = GetPlayerState(triggerer, PLAYER_STATE_RESOURCE_GOLD)
        set startlumber = GetPlayerState(triggerer, PLAYER_STATE_RESOURCE_LUMBER)
        set i = i + 1
        exitwhen i == bj_MAX_PLAYER_SLOTS
    endloop
    call TriggerAddCondition(t, Condition( function Cond))
    call TriggerAddAction(t, function Actions)
endfunction
endlibrary

Something like this can work? It is mui, even though it has globals. No waits.

[Rising_Dusk]

You can't use requirement to disable it like racial shops do?

And sustain the integer counts? No.

Something like this can work? It is mui, even though it has globals. No waits.

Yes, this works, but it doesn't keep the cooldowns for the units when it restores. That's the problem.

[Cecil]

Just stopping by... been awhile... why isn't 'c' out yet?